Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Introduce Auto-Releases #22

Merged
merged 1 commit into from
Oct 30, 2024
Merged

ci: Introduce Auto-Releases #22

merged 1 commit into from
Oct 30, 2024

Conversation

kellervater
Copy link
Member

Straight forward semVer release introduction. Did NOT introduce a conventional commits enforcer since it's a fork of a repo which doesn't use this standard.

Copy link
Member

@maxdanilov maxdanilov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it mean the version of the repo will start deviating from the logrotate version?

@kellervater
Copy link
Member Author

Yes, like discussed:

  • We could either close this one and leave it as is, because there are no high frequency releases
  • Or we approve this one and it deviates. But I'm not aware of any dependents which this may have an effect on
  • OR... we create some kind of sophisticated update scripts/ci which reflect the the version of logrotate when being changed. This would be achievable through a so called Release-As commit on the release-please PR. But that introduces a considerable amount of complexity and edge cases.

@maxdanilov
Copy link
Member

maxdanilov commented Oct 30, 2024

What I mean is, if we deviate from the logrotate version, that's fine, but then we need to pick another version aside from 3.21.0 as a starting version here (in .github/config/.release-please-manifest.json). The problem is that if that we don't, for the first releases it would create a false impression that we're still following the logrotate's version (like 3.21.1, 3.21.2 etc.)

Copy link
Member

@maxdanilov maxdanilov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment above for the versioning.

@kellervater
Copy link
Member Author

Then I'd say we bump to the next major version to clearly differentiate here.
It's possible like described in here: https://github.com/camunda/infra-actions-runner/pull/23#issuecomment-2446186173

@kellervater kellervater merged commit 5dd0a70 into master Oct 30, 2024
3 checks passed
@kellervater kellervater deleted the gh-614 branch October 30, 2024 13:46
@kellervater
Copy link
Member Author

For completeness:
We will bump to 4.0.0 with the next release:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants